Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support field names with underscores in search query #1180

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Support field names with underscores in search query #1180

merged 2 commits into from
Sep 10, 2018

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Sep 10, 2018 •
edited
Loading

fixes #1171

Summary

Allow _ characters in field names when parsing search queries.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios

@chandlerprall chandlerprall merged commit f149b02 into elastic:master Sep 10, 2018
@chandlerprall chandlerprall deleted the feature/1171-query-with-underscore-fields branch September 10, 2018 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bevacqua bevacqua bevacqua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search bar doesn't allow field names with _ in them
2 participants
@chandlerprall @bevacqua