Add direction prop for EuiFlexGroup typing #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
Sep 17, 2018
src/components/flex/index.d.ts
Outdated
| component?: FlexGroupCmponentType; | ||
| direction?: FlexGroupDirection; |
There was a problem hiding this comment.
since you're in this file already, mind adding the other missing prop type definitions?
justinkambic
commented
Sep 17, 2018
src/components/flex/index.d.ts
Outdated
| @@ -43,11 +48,12 @@ declare module '@elastic/eui' { | |||
| export type FlexGroupCmponentType = 'div' | 'span'; | |||
There was a problem hiding this comment.
@chandlerprall should we rename this type to FlexGroupComponentType? At first I thought it was an abbreviation but now I'm wondering if it wasn't meant to be that name all along?
chandlerprall
suggested changes
Sep 18, 2018
src/components/flex/index.d.ts
Outdated
| alignItems?: FlexGroupAlignItems; | ||
| children?: React.ReactNode; | ||
| className?: FlexGroupClassName; |
There was a problem hiding this comment.
className should be a string type
There was a problem hiding this comment.
Absolutely.. I read over className and saw componentType was PropTypes.oneOf(['div', 'span'])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the
directionprop of theEuiFlexGroupcomponent for TypeScript.Checklist
Note: any checks not completed were deemed unnecessary by me. Please let me know if any further check work needs to be done before this is ready to merge.