Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing EUI to use the lodash fork and forcing yarn usage #1217

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Sep 27, 2018

Summary

Updating lodash to our our private fork. This requires us to use yarn instead of npm because of the alias: syntax that we're using in the package.json to do so transparently. Otherwise, we'd have to update all references that import/require lodash to @elastic/lodash.

Checklist

~~ [ ] This was checked in mobile~~
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added
- [ ] A changelog entry exists and is marked appropriately
- [ ] This was checked for breaking changes and labeled appropriately
- [ ] Jest tests were updated or added to match the most common scenarios
- [ ] This was checked against keyboard-only and screenreader scenarios

@chandlerprall chandlerprall self-requested a review September 27, 2018 19:44
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; pulled and ran yarn successfully

@chandlerprall
Copy link
Contributor

for the package-lock.json conflict, I think we can simply delete that file

@kobelb kobelb merged commit 82823b7 into elastic:master Sep 27, 2018
@kobelb kobelb deleted the lodash-fork branch September 27, 2018 21:31
@teotoplak
Copy link

teotoplak commented Apr 9, 2019

Preinstall check script for yarn usage no longer needed since the upgrade of lodash to v4 (yarn alias is no longer used)?

@chandlerprall
Copy link
Contributor

Appears that way; I was able to npm install --ignore-scripts @elastic/eui without any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants