New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes for framer and mojave #1238

Merged

snide merged 2 commits into master from framer_fixes

Oct 15, 2018

Contributor

snide commented Oct 8, 2018 •

edited

Loading

Summary

This PR has two purposes:

Updates some dependencies so that EUI works in Mojave.
Adds a few exports to components so that it works properly with framer.

Checklist

~~This was checked in mobile~~
~~This was checked in IE11~~
~~This was checked in dark mode~~
~~Any props added have proper autodocs~~
~~Documentation examples were added~~
A changelog entry exists and is marked appropriately
~~This was checked for breaking changes and labeled appropriately~~
~~Jest tests were updated or added to match the most common scenarios~~
~~This was checked against keyboard-only and screenreader scenarios~~

chandlerprall approved these changes

View reviewed changes

Contributor

chandlerprall left a comment

changes LGTM

snide added 2 commits

October 15, 2018 11:28


          Some fixes for framer and mojave

eab2fc4

cl

3b0259e

snide force-pushed the framer_fixes branch from 1c9364c to 3b0259e Compare

October 15, 2018 18:32

snide merged commit bde75e5 into master

snide deleted the framer_fixes branch

October 15, 2018 18:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet