Add missing TS defs and fixing existing def #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TypeScript definitions for: - `EuiFormLabel` - `EuiSelect` Fix the `EuiTextColor` definition.
|
I've added a definition for |
chandlerprall
suggested changes
Oct 15, 2018
| * @see './field_number.js' | ||
| */ | ||
| export interface EuiFieldNumberProps { | ||
| icon?: string; |
There was a problem hiding this comment.
should be IconType imported from EuiIcon's index.d.ts
| */ | ||
|
|
||
| export type EuiFormLabelProps = CommonProps & | ||
| HTMLAttributes<HTMLLabelElement> & { |
There was a problem hiding this comment.
LabelHTMLAttributes instead of HTMLAttributes, LabelHTMLAttributes<HTMLLabelElement>
| */ | ||
|
|
||
| export type EuiSelectProps = CommonProps & | ||
| OptionHTMLAttributes<HTMLSelectElement> & { |
There was a problem hiding this comment.
SelectHTMLAttributes instead of OptionHTMLAttributes
chandlerprall
suggested changes
Oct 15, 2018
| /// <reference path="../../common.d.ts" /> | ||
|
|
||
| import { ReactNode, SFC, InputHTMLAttributes } from 'react'; | ||
| import { IconType } from '@elastic/eui' |
There was a problem hiding this comment.
Our approach for these is adding a reference to the icon file, e.g. /// <reference path="../icon/index.d.ts" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TypeScript definitions for
EuiFormLabelandEuiSelect, and fix theEuiTextColordefinition.I skipped the checklist for this PR as this is purely a TS definition change, and has no functional or visual change. I tested the changes during work on migrating a project to TS, which is how I discovered the issue.