Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definition changes #1247

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Conversation

pugnascotia
Copy link
Contributor

Add definitions for EuiAccordion, EuiDescriptionList, EuiForm, EuiFormHelpText and the accessibility services, and fix a number of small TS issues.

Add definitions for `EuiAccordion`, `EuiDescriptionList`, `EuiForm`,
`EuiFormHelpText` and the accessibility services, and fix a number of
small TS issues.
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change

src/components/form/checkbox/index.d.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM!

@pugnascotia pugnascotia merged commit a397d61 into elastic:master Oct 18, 2018
@pugnascotia pugnascotia deleted the more-ts-defs branch October 18, 2018 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants