Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TypeScript definitions for EuiFieldPassword #1255

Merged
merged 5 commits into from
Oct 23, 2018

Conversation

zumwalt
Copy link
Contributor

@zumwalt zumwalt commented Oct 19, 2018

No description provided.

Co-Authored-By: zumwalt <casey@zumwa.lt>
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more small change to enable that Ref usage, sorry!

src/components/form/field_password/index.d.ts Outdated Show resolved Hide resolved
Co-Authored-By: zumwalt <casey@zumwa.lt>
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zumwalt !!

@zumwalt zumwalt merged commit 5ad3f5f into elastic:master Oct 23, 2018
@zumwalt zumwalt deleted the zumwalt/ts-defs-for-form-fields branch October 23, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants