Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding APM trace icon #1263

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Adding APM trace icon #1263

merged 2 commits into from
Oct 25, 2018

Conversation

formgeist
Copy link
Contributor

Summary

Adding a new icon for APM for “trace”.

screenshot 2018-10-25 at 16 07 00

@formgeist
Adding APM trace icon
d1258fe 
Adding a new icon for APM for “trace”
@formgeist formgeist self-assigned this Oct 25, 2018
@formgeist formgeist requested a review from snide October 25, 2018 14:12
snide
snide approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor cleanup for the CL. One note: most of our gylphs don't use "frames". I know it's hard for APM, so it's it's OK, but just thought I'd mention it, since I don't know your usage.

CHANGELOG.md Outdated Show resolved Hide resolved
@snide @formgeist
Update CHANGELOG.md
e623f84 
Co-Authored-By: formgeist <casper@formgeist.com>
@formgeist
Copy link
Contributor Author

@snide Thanks for the suggest and feedback. Good to know about the frames, didn't really think of it that way. I might return to make some changes to it later.

@formgeist formgeist merged commit aa13912 into elastic:master Oct 25, 2018
@formgeist formgeist deleted the apm-trace-icon branch October 25, 2018 17:41
@chandlerprall chandlerprall mentioned this pull request Nov 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees

@formgeist formgeist

Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@formgeist @snide