Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing highContrastTextColor sass function #1275

Merged
merged 3 commits into from
Oct 31, 2018
Merged

Fixing highContrastTextColor sass function #1275

merged 3 commits into from
Oct 31, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Oct 31, 2018

The foreground is now adjusted based on the backgrounds brightness not the theme. It also includes fail safes to stop the @while from running if it reaches a certain lightness level (can’t lighten/darken any further).

To test

Try changing any tintOrShade to just tint or shade.

Fixing highContrastTextColor sass function
e91adfc 
The foreground is now adjusted based on the backgrounds brightness not the theme. It also includes fail safes to stop the `@while` from running if it reaches a certain lightness level (can’t lighten/darken any further).
snide
snide approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is a great change.

We should add a CL for this, even though it's just the Sass layer.

@cchaos
Copy link
Contributor Author

cchaos commented Oct 31, 2018

Yep, whoops, forgot. I guess it's been a while....

ryankeairns
ryankeairns approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having poked around at the code, I had made the assumption it already worked in this manner. Expectations now meet reality which is a great place to be, nice enhancement :)

@cchaos cchaos merged commit 937c8e1 into elastic:master Oct 31, 2018
@cchaos cchaos deleted the fix-color-function branch October 31, 2018 20:20
@chandlerprall chandlerprall mentioned this pull request Nov 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cchaos @snide @ryankeairns