-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New product logos #1279
New product logos #1279
Conversation
cc @JessSmithSup @Michalwo I noticed some shape clippings because of the stack of these shapes on top of each other. It's only noticable on Dark, which likely would need touchups to work anyway. In 6.5 you don't need to worry about dark mode yet. |
@snide I have a version that has no overlapping, I can export if we need it. Do you think that will solve it? |
@JessSmithSup Honestly I don't think it's something we need to worry about immediately (it's invisible on white, which is the only place we'd see them in 6.5). If you feel otherwise though feel free to update the Sketch EUI Libraries/logos file with your newer versions and I can move them in. I think we do need a strategy for what do do with these in dark mode in the 7.0 world though. I could prolly adjust the colors manually per theme if we wanted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Yeah these don't work so well with swapping the dark gray #343741
with our text color (in dark theme), so it'll probably need to be a manual decision.
@@ -1,5 +1,7 @@ | |||
## [`master`](https://github.com/elastic/eui/tree/master) | |||
|
|||
- Added updated and new product logos to `EuiIcon` ([#1279](https://github.com/elastic/eui/pull/1279)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added & updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update is subsequent PR
Summary
Summarize your PR. If it includes design elements include a screenshot or gif.
Checklist
[ ] This was checked in mobile[ ] This was checked in IE11[ ] Any props added have proper autodocs[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components