Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds lab icon and updates beta badge style #1291

Merged
merged 4 commits into from
Nov 6, 2018

Conversation

ryankeairns
Copy link
Contributor

Fixes #1280

Summary

In response to feedback and discussion around the current beta badge (see links in issue above), we're updating the EuiBetaBadge design to be more subtle, visually. Additionally, this PR adds a lab icon that can be used for icon-only beta badges.

screenshot 2018-11-06 11 04 51

screenshot 2018-11-06 11 05 10

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide
Copy link
Contributor

snide commented Nov 6, 2018

cc @tbragin and @skearns64. We'll get this into 6.5

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is a rush to get this in, I'm good with the changes (minus the icon naming tweak).

The new badge style looks great on the cards, but it falls a little in the keypad menu item version. But we can tackle that later.

screen shot 2018-11-06 at 12 39 41 pm

src-docs/src/views/badge/beta_badge.js Outdated Show resolved Hide resolved
@ryankeairns
Copy link
Contributor Author

retest

@ryankeairns
Copy link
Contributor Author

jenkins, test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants