Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'baseline' value to EuiFlexGroup's FlexGroupAlignItems type #1329

Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Nov 26, 2018

Summary

Fixes #1325 by adding baseline as a possible value to EuiFlexGroup's FlexGroupAlignItems type for alignItems prop

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added

  • A changelog entry exists and is marked appropriately
    - [ ] This was checked for breaking changes and labeled appropriately
    - [ ] Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    ~- [ ] This required updates to Framer X components`

@chandlerprall chandlerprall merged commit a3e7b4a into elastic:master Nov 29, 2018
@chandlerprall chandlerprall deleted the bug/1325-flexgroup-alignitems-types branch November 29, 2018 20:03
@snide snide mentioned this pull request Nov 30, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants