Convert EuiIcon to TypeScript #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
Dec 7, 2018
| if (COLORS.indexOf(color) > -1) { | ||
| optionalColorClass = colorToClassMap[color]; | ||
| if (color) { | ||
| checkValidColor(color, type || 'empty'); |
There was a problem hiding this comment.
Interesting way to re-implement this prop type, I like it!
|
That babel warning is fine. It's on our roadmap to begin addressing EuiIcon's overall size. |
|
@chandlerprall I've pushed some review feedback, but the prop types generator fails on these again. Might be the |
|
Cancel that - everything's good after rebasing, so I've also inlined that interface that I mentioned above. 🙌 |
pugnascotia
force-pushed
the
convert-icon-to-ts
branch
from
0658cb4
to
0cae82e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert the
EuiIconcomponent to TypeScript. Notes:tscandtslint, as TSLint recommends that compilation run cleanly before linting.Something else to note is that I'm seeing the following warning when building EUI now:
True enough, if you look at the output in
lib/, it's...ugly. I ran it through Prettier, and did the same formaster, and the output varies in the expected ways but not by that much. Perhaps I just inched over the threshold? I did wonder if we should stop using the plugin and write a script to callsvgoand generate actual component files instead? In any case, I started the docs site locally and the icons looked fine.Checklist