-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creative + product coloring #1356
Conversation
Hey all. We got together with @JessSmithSup to get our color schemes closer to brand. These all pass the same AA checks they did before, but the colors were cooled a bit. Biggest change is the addition of some blue hues to our grays and an overall brightening of the palette. If anyone has any comments or concerns, give a yell. We'll merge this sometime in the next week and its very easy to adjust. |
Not sure I agree with gray, but we can probably saturate them more or something. The focus is important for lots of places beyond this example. Agree it needs some work.
Somewhat there for accessibility to give another point of reference, but it doesn't need to be there. I can try removing.
Or should default be something else? Rest of these I agree with and can adjust. |
Yeah both the hover color and badge statements were more along the lines of "these are now very close in color and maybe should be tweaked in some fashion". I'd like to see the buttons without the darker hover state. |
@cchaos This is ready for another gander. Everything but the buttons were addressed. |
OK. Think we're good on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with these, I'm unable to test in cloud yet, so once its merged I'll pull in and scramble.
Summary
Updates EUI colors to match more against brand.
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] Any props added have proper autodocs- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This required updates to Framer X components