Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creative + product coloring #1356

Merged
merged 11 commits into from
Dec 11, 2018
Merged

creative + product coloring #1356

merged 11 commits into from
Dec 11, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Dec 7, 2018

Summary

Updates EUI colors to match more against brand.

image

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11

  • This was checked in dark mode
    - [ ] Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
    - [ ] This was checked for breaking changes and labeled appropriately
    - [ ] Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

@snide
Copy link
Contributor Author

snide commented Dec 7, 2018

Hey all. We got together with @JessSmithSup to get our color schemes closer to brand. These all pass the same AA checks they did before, but the colors were cooled a bit. Biggest change is the addition of some blue hues to our grays and an overall brightening of the palette.

If anyone has any comments or concerns, give a yell. We'll merge this sometime in the next week and its very easy to adjust.

@snide snide requested a review from gjones December 7, 2018 19:01
@cchaos
Copy link
Contributor

cchaos commented Dec 7, 2018

Man, it is so nice to have all these documented so it's easy to see how the color affects all the components.

Important changes needed

1. Fix horizontal steps background
screen shot 2018-12-07 at 14 23 48 pm

2. Let's make the bottom border of the selected double 2px high. It's hard to see.
screen shot 2018-12-07 at 14 24 30 pm

3. Form control placeholder text
screen shot 2018-12-07 at 14 33 31 pm

4. Disabled switch and checkbox/radios compared to their label color (so close, they maybe should be the same)
screen shot 2018-12-07 at 14 34 35 pm
screen shot 2018-12-07 at 14 35 43 pm

Slightly less important (can wait)

a. Remove $euiColorSlightHue

b. I think the highlight colors we use now (lighter color of primary) are really close to the grays and can probably just switch to using a gray
screen shot 2018-12-07 at 14 18 54 pm
Same with the sub-steps:
screen shot 2018-12-07 at 14 22 12 pm
And table footers
screen shot 2018-12-07 at 14 31 15 pm

c. Do we need to be darkening buttons on hover? I think the movement and underline is enough. It takes away from the nice colors.

d. Should the primary badge be lightly more blue?
screen shot 2018-12-07 at 14 25 51 pm

e. May want to revisit some code coloring and make it so it's more of permutations on the existing colors and not hard-coded hex values
screen shot 2018-12-07 at 14 27 29 pm

Docs only

i. Update the little previews
screen shot 2018-12-07 at 14 15 00 pm

ii. Do the color palettes need to be updated too?
screen shot 2018-12-07 at 14 37 05 pm


I'm not even getting into dark mode right now

@snide
Copy link
Contributor Author

snide commented Dec 7, 2018

I think the highlight colors we use now (lighter color of primary) are really close to the grays and can probably just switch to using a gray

Not sure I agree with gray, but we can probably saturate them more or something. The focus is important for lots of places beyond this example. Agree it needs some work.

Do we need to be darkening buttons on hover? I think the movement and underline is enough. It takes away from the nice colors.

Somewhat there for accessibility to give another point of reference, but it doesn't need to be there. I can try removing.

Should the primary badge be lightly more blue?

Or should default be something else?

Rest of these I agree with and can adjust.

@cchaos
Copy link
Contributor

cchaos commented Dec 7, 2018

Yeah both the hover color and badge statements were more along the lines of "these are now very close in color and maybe should be tweaked in some fashion".

I'd like to see the buttons without the darker hover state.

@snide
Copy link
Contributor Author

snide commented Dec 10, 2018

@cchaos This is ready for another gander. Everything but the buttons were addressed.

src/components/steps/_steps_horizontal.scss Outdated Show resolved Hide resolved
src/components/form/_mixins.scss Outdated Show resolved Hide resolved
src/components/form/switch/_switch.scss Outdated Show resolved Hide resolved
@snide
Copy link
Contributor Author

snide commented Dec 11, 2018

OK. Think we're good on this.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@gjones gjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with these, I'm unable to test in cloud yet, so once its merged I'll pull in and scramble.

@snide snide merged commit 2f13e18 into elastic:master Dec 11, 2018
@snide snide deleted the brand/colors branch December 11, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants