-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert EuiExpression to TS #1368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got rid of `EuiExpressionButton`
cchaos
commented
Dec 12, 2018
snide
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor design questions, that I'm fine with either way. Looks a lot better.
chandlerprall
approved these changes
Dec 14, 2018
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more
EuiExpressionButton
The breaking change on this is that there were 2 components
EuiExpression
andEuiExpressionButton
.EuiExpression
did absolutely nothing but be a div wrapper. So I removed theEuiExpressionButton
as the name was limiting and just made itEuiExpression
.More options
I also added more options to the
EuiExpression
:color
: for specifying the color of thedescription
(defaults to 'success')uppercase
: for telling the component to or not to uppercase thedescription
(defaults to true)onClick
: now this option forces the component to be a button with some styles associated with click-ability otherwise if a function is not provided it will be a "ready only" style.I also changed the font family to our mono spaced font, and reduced some of the height for a more compressed look.
cc @nreese
Checklist
[ ] This required updates to Framer X components