fix EuiSuperSelect from accessing ref when unmounted #1369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The kibana GIS app places an EuiSuperSelect in a FlexItem that is unmounted when the user clicks cancel (first screen shot). If the menu is open when the cancel button is clicked, the EuiSuperSelect will be unmounted but
focusSelected
gets called afterward, viarequestAnimationFrame
, and this causes a hard crash (second screen shot, third error message). This PR just adds a check to ensure the component is still mounted before proceeding with the contents of therequestAnimationFrame
callback.Checklist