Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the currently selected item selected in the dropdown in single selection mode #1391

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Keep the currently selected item selected in the dropdown in single selection mode #1391

merged 2 commits into from
Jan 3, 2019

Conversation

trevan
Copy link
Contributor

@trevan trevan commented Dec 20, 2018

Fixes #1386

In single selection mode, when the option list is rendered, it will have the current option highlighted.

single_selection

I didn't create any new props but if you don't want this to be the default behavior, I could create a new property under singleSelection to control this.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

chandlerprall
chandlerprall suggested changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing these up! Requesting 2 small changes before merging.

src/components/combo_box/combo_box.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
chandlerprall
chandlerprall approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again

chandlerprall
chandlerprall suggested changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jumped the gun - need a CI run

@chandlerprall
Copy link
Contributor

jenkins test this

@chandlerprall
Copy link
Contributor

jenkins test this

known flaky unit test

chandlerprall
chandlerprall approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, merging

@chandlerprall chandlerprall merged commit 8b81242 into elastic:master Jan 3, 2019
@snide
Copy link
Contributor

snide commented Jan 3, 2019

Congrats @trevan on your first EUI PR. Thanks for contributing.

@trevan
Copy link
Contributor Author

trevan commented Jan 3, 2019

@chandlerprall, @snide, thanks

@trevan trevan deleted the combo-box-single-select branch January 3, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trevan @elasticmachine @chandlerprall @snide