Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude custom_typings from eui.d.ts #1395

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Exclude custom_typings from eui.d.ts #1395

merged 1 commit into from
Dec 21, 2018

Conversation

pugnascotia
Copy link
Contributor

Summary

Closes #1388. The src/custom_typings directory contains some TS definitions that allows TS files to import images without complaint. However, these definitions were being included in eui.d.ts, which meant downstream projects couldn't include their own mechanisms for importing images. The fix is to exclude custom_typings from eui.d.ts

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

snide
snide approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

@pugnascotia pugnascotia merged commit c0cda96 into elastic:master Dec 21, 2018
@pugnascotia pugnascotia deleted the 1388-exclude-custom-typings branch December 21, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eui.d.ts declares non-eui modules
2 participants
@pugnascotia @snide