Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onBlur prop to EuiComboBox #1400

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Add onBlur prop to EuiComboBox #1400

merged 2 commits into from
Jan 4, 2019

Conversation

zumwalt
Copy link
Contributor

@zumwalt zumwalt commented Jan 2, 2019

Summary

This PR enables the onBlur prop for EuiComboBox.

Checklist

  • [ ] This was checked in mobile
  • [ ] This was checked in IE11
  • [ ] This was checked in dark mode
  • Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

snide
snide approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a functionality test on this to verify everything worked as normal and did a quick scan on the code. LGTM.

@chandlerprall
Copy link
Contributor

CI error is a couple snapshots needing updates.

@zumwalt zumwalt merged commit a28be25 into elastic:master Jan 4, 2019
@zumwalt zumwalt deleted the euiComboBox-onBlur branch January 4, 2019 23:01
@chandlerprall chandlerprall mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zumwalt @chandlerprall @snide