Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining accessibility files to TS #1408

Merged
merged 5 commits into from
Jan 9, 2019
Merged

Migrate remaining accessibility files to TS #1408

merged 5 commits into from
Jan 9, 2019

Conversation

pugnascotia
Copy link
Contributor

Summary

Migrate the remaining non-TS files under src/components/accessibility/ to TS.

I also replaced uses of sinon with Jest mocks.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@pugnascotia
Copy link
Contributor Author

@chandlerprall Thanks for the review, I've addressed your comments.

chandlerprall
chandlerprall approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pugnascotia pugnascotia merged commit bb02e2b into elastic:master Jan 9, 2019
@pugnascotia pugnascotia deleted the accessibility-to-ts branch January 9, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pugnascotia @chandlerprall