Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds initialFocus prop typedefs #1410

Merged
merged 6 commits into from
Jan 7, 2019
Merged

Adds initialFocus prop typedefs #1410

merged 6 commits into from
Jan 7, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Jan 7, 2019

Summary

Adds type definitions for the initialFocus prop available on EuiModal and EuiPopover

(discovered via elastic/kibana#28195)

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@legrego
Copy link
Member Author

legrego commented Jan 7, 2019

@chandlerprall I added you for review because I think you're the resident TS expert, but let me know if there's someone else who should review instead

chandlerprall
chandlerprall suggested changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for better prop definition. Also needs an entry to CHANGELOG.md (you beat me to the changelog)

src/components/popover/index.d.ts Outdated Show resolved Hide resolved
src/components/modal/index.d.ts Outdated Show resolved Hide resolved
@legrego
Copy link
Member Author

legrego commented Jan 7, 2019

@chandlerprall thanks for the feedback, I wasn't aware of that definition! I think I've addressed everything if you want to take another look.

chandlerprall
chandlerprall approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @legrego!

@legrego legrego merged commit 2fa8847 into elastic:master Jan 7, 2019
@legrego legrego deleted the adds-initialFocusProp-typedefs branch January 7, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legrego @chandlerprall