Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GIS app icon #1413

Merged
merged 6 commits into from
Jan 8, 2019
Merged

Update GIS app icon #1413

merged 6 commits into from
Jan 8, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jan 7, 2019

Summary

screen shot 2019-01-07 at 18 33 38 pm

screen shot 2019-01-07 at 18 33 33 pm

I also removed the emsApp icon from the documentation but left it in as an icon type to avoid breaking changes.

Checklist

  • [ ] This was checked in mobile
  • [ ] This was checked in IE11
  • This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos cchaos added the icons label Jan 7, 2019
@cchaos cchaos requested a review from snide January 7, 2019 23:38
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@cchaos cchaos merged commit 4a351c1 into elastic:master Jan 8, 2019
@cchaos cchaos deleted the gisAppIcon branch January 8, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants