[WIP] EuiTableHeaderCell a11y #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f sort behavior and state; update snapshort
cjcenizal
reviewed
Jan 15, 2019
There was a problem hiding this comment.
👏 Awesome work! I tested locally and I think this is the right direction. I have a few suggestions.
Announcing sort direction changes
Currently, if you change the sort on the column then screen reader won't tell you about the state change. Can we use aria-live or role="alert" to announce changes to the sort direction?
Docs discoverability
Can we add sortable: true to all of the columns in the Sorting example, to make it easier to discover and test this functionality? Currently only a couple of the columns are sortable.
cjcenizal
reviewed
Jan 22, 2019
cjcenizal
reviewed
Jan 23, 2019
cjcenizal
approved these changes
Jan 23, 2019
chandlerprall
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Changes LGTM (and thanks @cjcenizal for the intricate testing!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1378.
Uses a combination of
aria-sortand conditional, visually hidden state descriptions to compliment the cell text for screen readers.Feedback welcomed
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This required updates to Framer X components