-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds side nav component (EuiNavDrawer) #1427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just after a quick glance, it's looking really good, just some issues around responsive and scrolling.
The header buttons with notifications need to be modified so the notification badge doesn't cover the icon this much.
At the small breakpoint, there's still a size issue
The secondary drawer should scroll independently
It's weird that on mobile I can see the full width of the buttons when I click on them
On mobile it would be nice to be able to use the overlay so that clicking outside of the nav will close it.
Pushed up changes for:
Still need to do:
|
|
@chandlerprall Since icons are wrapped in button elements, serving as secondary actions separate from the main button, do the svg icons need the |
Closes: elastic/kibana#25736 and potentially elastic/kibana#25741 |
@chandlerprall The drawer will now collapse upon tabbing out. If you have some time to check out the focus-trap bit, that would be much appreciated. I think that is the last piece to the puzzle here in terms of interaction work. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! Congrats! Let's get this sucker in and we will probably need a follow up after the stab at putting it into Kibana with possible unknowns. Unless @chandlerprall sees anything glaring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
THIS IS EXCITING |
The focus-trap component introduces a hiccup in the animation when expanding the flyout. Looking into that, then will merge! |
This reverts commit 680a0fb.
Haha, I just realized there's no changelog though 😜 |
Summary
Adds a component named
EuiNavDrawer
that wraps one or moreEuiListGroup
components into an interactive side nav. It is designed to be used in conjunction withEuiHeader
and, relatedly, resulted in a couple of minor changes to theEuiHeader
design, most notably shortening its height from 64 to 48 pixels.Note about keyboard accessibility
While keyboard accessibility is possible, it would be improved by using focus-trap for the sub menu that slides out. I attempted to get this working and while I could trap the focus in the flyout/sub menu, I could not get it to return focus to the triggering element upon pressing the
esc
key.Long story short, I could use some help sorting this out.
To-do items
Recordings
Interaction on desktop
Interaction on mobile
Checklist
This required updates to Framer X components