Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollback @types versions for react & prop-types to support Kibana #1435

Merged
merged 2 commits into from
Jan 15, 2019
Merged

rollback @types versions for react & prop-types to support Kibana #1435

merged 2 commits into from
Jan 15, 2019

Conversation

chandlerprall
Copy link
Contributor

Summary

Aligns EUI's @types/react & @types/prop-types versions with Kibana

@chandlerprall chandlerprall requested a review from nreese January 14, 2019 23:31
nreese
nreese approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Thanks for doing this and making the Kibana EUI upgraded easy

@nreese
Copy link
Contributor

nreese commented Jan 15, 2019

Maybe add change log?

@chandlerprall chandlerprall merged commit a719882 into elastic:master Jan 15, 2019
@chandlerprall chandlerprall deleted the rollback-type-versions branch January 15, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandlerprall @nreese