-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple fixes for mobile tables #1462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we trigger a console.warn
if a deprecated prop is used?
aa3537f
to
f9078a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small TS change, otherwise proptypes and ts defs look great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sweet. Ok, then I'll update all other table examples to use the proper props. |
d495ff3
to
63a592b
Compare
235f90a
to
aa54cc8
Compare
Ok, I think I'm done with this PR finally. 🥇 @chandlerprall Can you do a double check mainly just on this file: https://github.com/elastic/eui/pull/1462/files#diff-cca6a37365f48c17b61c1ad941a710c1 and especially concerning the select all checkbox where I ended up having to append a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes still LGTM
And added back in all the i18n stuff
1a4ec33
to
1a8a81a
Compare
1. Better singular prop object
mobileOptions object accepts the following:
That means the following props are being deprecated:
mobileOptions.header
mobileOptions.only = true
&mobileOptions.header = false
mobileOptions.show = false
mobileOptions.fullWidth
Example
2. The mobileOptions.header prop accepts a node for rendering
... Instead of using the CSS
content: attr(data-header)
trick. It's displayed directly in the DOM. Fixes #1315cc @cjcenizal
3. EuiBasicTable properly adds support for the mobile version of "Select all"
Fixes #1036
Deprecation Notice
Again, this deprecates some of the responsive-only props in favor of the
mobileOptions
object. However, it is currently not a breaking change. The old props will still work, but the object will override them if both are provided.Testing
So I've left all but the Responsive and Custom examples as they were, to ensure that these are still working. Then when I get approval of the new object prop, I will update all the examples to use the proper prop.
I also ran this through Kibana via
yarn link
and went through a bunch of table-heavy pages and didn't come up with any breaks. Though I didn't run it through any tests.Checklist
[ ] This required updates to Framer X components