Font reset is more precise, fix form label weights #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
commented
Jan 24, 2019
| @@ -32,13 +26,15 @@ time, mark, audio, video { | |||
| margin: 0; | |||
| padding: 0; | |||
| border: none; | |||
| font: inherit; /* 1 */ | |||
| font-family: inherit; /* 1 */ | |||
There was a problem hiding this comment.
Note that the HTML tag below will still apply the correct font, which is why it's OK to remove it here.
cchaos
approved these changes
Jan 24, 2019
|
This didn't fix the rendering issue for me, but the calculated font-family is correct now. I suspect it's my machine that is the issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@w33ble noticed some inheritance problems with fonts in elastic/kibana#29152. I also heard word from @gjones that there was some other weirdness going on in Cloud. @cchaos and I tracked it down to some over reliance on
inheritwith our reset file. We only use two fonts in EUI, the codey one and the not codey one. More explicitly declaring these in our reset fixes the issues we saw with Joe.@cchaos I added pre on here because it fits the definition of the default. https://www.w3schools.com/tags/tag_pre.asp
Note to @zumwalt, since I like to alert everyone anytime I edit a reset file in EUI.
I also upped the weight of the form labels, which were a little weak with the new font.
Checklist
This was checked in mobileThis was checked in dark modeAny props added have proper autodocsDocumentation examples were addedThis was checked for breaking changes and labeled appropriatelyJest tests were updated or added to match the most common scenariosThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components