Don’t reduce header at at mobile size #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
approved these changes
Jan 25, 2019
|
@ryankeairns You good with these changes? |
ryankeairns
reviewed
Jan 28, 2019
ryankeairns
approved these changes
Jan 28, 2019
|
Just want to add my +1 for this as I'm seeing issues with the search box on mobile in Cloud.
https://elastic.slack.com/archives/C7QC1JV6F/p1548686989609400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The header was being too squished in height on mobile screens. This PR just keeps the height from changing (but still allows the buttons to squish in width).
Note
To @ryankeairns : I moved the
min-width: 49pxto just the header logo because it was causing the spaces avatar to look off-center. Though when I look at it without that the button seems to still render at 49px wide (probably because the 'border' is atright: 0. But anyhow, you can double-check that part and let me know if you'd rather me put it back the way it was.Checklist
[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components