Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated popover position to correctly address arrow buffer #1490

Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Jan 29, 2019

Summary

Addresses a bug @nreese found in elastic/kibana#29235

The tooltip has a whitespace buffer of 16px, and its arrow must be 4px from its edge. Nathan's super update button is less than 16px from the right side of the screen; the calculations were shifting the popover to meet the buffer but didn't properly account for the 4px needed for the arrow, which forced the popover to an undesired position.

@nreese mind building the fix and confirming it works in your Kibana branch?

Checklist

  • This was checked in mobile
    - [ ] This was checked in IE11
    - [ ] This was checked in dark mode
    - [ ] Any props added have proper autodocs
    - [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

@chandlerprall chandlerprall removed the request for review from thompsongl January 29, 2019 19:11
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Tested changes in Kibana and now the tooltip stays on the bottom.

@chandlerprall chandlerprall merged commit 3eec2d3 into elastic:master Jan 29, 2019
@chandlerprall chandlerprall deleted the bug/double-applied-popover-buffer branch January 29, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants