Form fields now have a loading state #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattapperson
approved these changes
Nov 15, 2017
| } from 'react'; | ||
|
|
||
| import { | ||
| EuiCheckboxGroup, |
There was a problem hiding this comment.
You are importing a number of things here you are not using. Not sure that it really matters all that much but thought I would mention it
There was a problem hiding this comment.
Good catch. Hey @cjcenizal or @bevacqua. It'd be nice if our pre-commit stuff caught this kind of thing again. Was really helpful.
snide
force-pushed
the
feature/form_loading
branch
from
68f0527
to
2fbccc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146
Add
isLoadingto any text based form field to signify the input is in a loading state. This can be provided in combo with props likedisabledif needed.