Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ligature issue in ACE #1505

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Fix ligature issue in ACE #1505

merged 2 commits into from
Feb 1, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Feb 1, 2019

Summary

@bmcconaghy noticed some issues with console and tracked to down to a Kibana upgrade of EUI from 6.3.1 to 6.5.1. I picked up the trail and tracked it down to these lines

https://github.com/elastic/eui/blob/master/src/global_styling/mixins/_typography.scss#L12
https://github.com/elastic/eui/blob/master/src/global_styling/variables/_typography.scss#L30

I don't think this is a problem with the code in EUI but a weird bug in ACE and the way they calculate cursor position based off character widths. Unfortunately we use ACE everywhere in Kibana and I'd rather cut this off here than add a lot of overwrites into our ACE implementation there. I'll be honest and say I don't know enough about this property to understand much of what it does other than effect kerning. I couldn't notice any difference in the render, but I have old eyes 😄

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested a review from cchaos February 1, 2019 02:54
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comment in there too

@snide snide changed the title fix kern issue in ACE Fix ligature issue in ACE Feb 1, 2019
@snide snide merged commit 35269b9 into elastic:master Feb 1, 2019
@snide snide deleted the typo/kerns branch February 1, 2019 18:57
@snide snide mentioned this pull request Feb 1, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants