Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight tweak with dark bg color #1530

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Slight tweak with dark bg color #1530

merged 2 commits into from
Feb 6, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Feb 5, 2019

Summary

Related to elastic/kibana#30136 (comment)

Makes the dark BG less dark so that it fits closer to the contrast patterns we have going in the light mode.

image

image

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested a review from cchaos February 5, 2019 23:50
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snide snide merged commit 9a95b69 into elastic:master Feb 6, 2019
@snide snide deleted the eui/bg branch February 6, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants