EuiSuperDatePicker handle invalid start and end property values #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Shigawire
pushed a commit
to Shigawire/eui
that referenced
this pull request
May 10, 2019
…tic#1544) * EuiSuperDatePicker handle invalid start and end property values * change log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EuiSuperDatePicker start and end props expect string values. This PR makes sure invalid values do not crash the component and allow users to recover by keeping the component working so they can set valid values. The PR updates the docs example so users can set anything for start and end and see how it behaves
dateMath.parse returns undefined for values like
now--15mand an invalid moment for values likebadinput. The logic had to be updated to ensure the moment returned from dateMath.parse exists and is also valid