Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Euilink supports text color #1571

Merged
merged 5 commits into from
Feb 15, 2019
Merged

Euilink supports text color #1571

merged 5 commits into from
Feb 15, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Feb 15, 2019 •
edited
Loading

Summary

Every once in awhile you need a link to look like the text. This matches what EuiButtonEmpty has, but doesn't come with all the padding. @nreese needed this for a maps menu.

image

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested a review from nreese February 15, 2019 20:42
nreese
nreese approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this

lgtm
code review

@nreese nreese mentioned this pull request Feb 15, 2019
Merged
cchaos
cchaos approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick docs change and CL typo. Checked in Chrome.

CHANGELOG.md Outdated Show resolved Hide resolved
src-docs/src/views/link/link.js Outdated Show resolved Hide resolved
src/components/link/_link.scss Show resolved Hide resolved
@snide snide merged commit bb9a1ec into elastic:master Feb 15, 2019
@snide snide deleted the link/text branch February 15, 2019 23:49
@maryia-lapata maryia-lapata mentioned this pull request Mar 1, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snide @nreese @cchaos