A few fixes required to get eui@8.x working in Kibana #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I saw that and fixed in #1589 as @thompsongl said. That should be going in soon. |
@thompsongl thanks! I am going to leave this open temporarily while I am working through a ton of other errors I'm seeing in Kibana with eui@8.x. Not sure if they are Kibana errors or EUI errors or Jason errors yet. |
jasonrhodes
force-pushed
the
fix-8.0-in-kibana
branch
from
102903a
to
b3f3f4c
Compare
chandlerprall
approved these changes
Feb 26, 2019
thompsongl
approved these changes
Feb 26, 2019
| @@ -14,6 +14,7 @@ declare module '@elastic/eui' { | |||
| export interface EuiFilterButtonProps { | |||
| numFilters?: number; | |||
| numActiveFilters?: number; | |||
| hasActiveFilters?: boolean; | |||
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EuiEmptyButtonPropsbut it accepts about 5 extra props)