Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] - Added props doc mentioning the activePage is zero based #1740

Merged
merged 3 commits into from
Mar 20, 2019
Merged

[Pagination] - Added props doc mentioning the activePage is zero based #1740

merged 3 commits into from
Mar 20, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented Mar 19, 2019

Summary

Included documentation entry for activePage prop mentioning that the activePage is zero based.
Ref: #1667

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@chandlerprall
Copy link
Contributor

jenkins test this

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; built docs locally and verified the change appears as expected

@chandlerprall
Copy link
Contributor

@theodesp can you move the changelog entry to the top of the log? Unfortunately the way we write them, git associates the entries with the above/below lines and your change is now associated with a released version. With that update I'll merge this in!

@theodesp
Copy link
Contributor Author

@chandlerprall I've moved the entry to the current master

@theodesp
Copy link
Contributor Author

I have updated my Changelog to reflect the latest changes. Thanx

@thompsongl
Copy link
Contributor

jenkins test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants