[EuiSuperDatePicker] Invoke onRefresh
instead of onTimeChanged
when clicking “Refresh”
#1745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1577
Since there is now an
onRefresh
callback, the update button should no longer callonTimeChanged
when an actual refresh was performed (which doesn't change the time).The ui of the button already distinguishes between the two states (update time range vs. manual refresh).
This is also the same callback that will be called, when the automatic refresh interval is fired.
This is important because the consumer might want to have separate logic for when the time range was changed vs. when a refresh was invoked.
To make this backwards compatible this change only take effect for consumers who have implemented the
onRefresh
callback (searching through Kibana this will only affect APM)