Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings, and <p>, need to inherit #1776

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Mar 28, 2019

Fixing the previous fix of #1760 where setting the font size at the reset level was causing these tags not to inherit from their container. Even the text scales weren't working:

So now, all 3 properties are just set to inherit (which should be from the html tag which does set the size, family and weight.

Now:

back to normal

Checklist

  • This was checked in Kibana
  • [ ] This was checked in mobile
  • This was checked in IE11
  • [ ] This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • [ ] Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos
Copy link
Contributor Author

cchaos commented Mar 28, 2019

@formgeist Originally caught this in the KQL autocomplete:

image

@cchaos
Copy link
Contributor Author

cchaos commented Mar 28, 2019

And here's what it now looks like in Kibana:

Screen Shot 2019-03-28 at 10 05 22 AM

As well as the originally issue

Screen Shot 2019-03-28 at 10 06 16 AM

Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cchaos cchaos merged commit 30f9957 into elastic:master Mar 28, 2019
@cchaos cchaos deleted the resets-are-hard branch March 28, 2019 15:59
@snide snide mentioned this pull request Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants