Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small accessibility fixes to toasts and combo box #1803

Merged
merged 7 commits into from
Apr 9, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Apr 6, 2019

Summary

Easy one while I was cleaning out the backlog. As long as an item within a toast has focus, it will stick around. When you tab out, it will resume the countdown, similar to mouse actions.

Fixes #717

Also added a fixes #1343. Given how direct the combo box is with instruction it seemed like the best thing to do was announce the placeholder in the same way.

image

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide changed the title Toasts no longer dismiss when they hold focus Small accessibility fixes to toasts and combo box Apr 6, 2019
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the toast also still persist if the user has clicked inside it, example is selecting text:

@snide
Copy link
Contributor Author

snide commented Apr 9, 2019

This is ready for a final review I think. I don't know how to address the text selection stuff, but between the mouse hover and the tabbing inside I think it's good enough to close out that old ticket.

@snide snide merged commit 49eaac1 into elastic:master Apr 9, 2019
@snide snide deleted the a11y/toats branch April 9, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants