Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cache-loader to speed up development docs site builds #1841

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Use cache-loader to speed up development docs site builds #1841

merged 4 commits into from
Apr 17, 2019

Conversation

pugnascotia
Copy link
Contributor

The docs site build takes a long time to finish and serve during development. This PR applies cache-loader during development. I saw a time reduction from 183s to 18s.

@pugnascotia pugnascotia added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Apr 16, 2019
@chandlerprall
Copy link
Contributor

Aaahahhhhh my dev startup went from 113s to 19s. ❤️

chandlerprall
chandlerprall suggested changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise this is fantastic

.gitignore Outdated Show resolved Hide resolved
chandlerprall
chandlerprall approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled and ran locally to verify

@pugnascotia pugnascotia merged commit 90199c5 into elastic:master Apr 17, 2019
@pugnascotia pugnascotia deleted the use-cache-loader branch April 17, 2019 14:34
@thompsongl thompsongl mentioned this pull request Apr 17, 2019
Closed
This was referenced Apr 22, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pugnascotia @chandlerprall