Convert EuiStat to TSX, add isLoading prop, add tests #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
reviewed
Apr 17, 2019
|
👍 Nice, simple solution. |
snide
changed the title
snide
commented
Apr 18, 2019
| // @ts-ignore | ||
| <EuiI18n token="euiStat.loadingText" default="Statistic is loading"> | ||
| {/* // @ts-ignore */} | ||
| {(loadingText: string) => <p aria-label={loadingText}>--</p>} |
There was a problem hiding this comment.
re: TS error around EuiI18n usage.
|
K, went ahead and converted this component to TS. Had a minor hiccup with our 18n service, but otherwise should be reviewable. |
chandlerprall
approved these changes
Apr 19, 2019
cchaos
suggested changes
Apr 22, 2019
|
We should also think about beefing up the tests https://github.com/elastic/eui/blob/aec7577e20036f998981ca8fdbc0e3267ec36b5a/src/components/stat/stat.test.js and adding some snippets. |
Co-Authored-By: snide <dave.snider@gmail.com>
Co-Authored-By: snide <dave.snider@gmail.com>
|
"Oh, I'll just add a prop" somehow turned into "Let me rewrite this in typescript, add tests and fix a bunch of accessibility and docs issues". I think I got to all the requests though 😉 |
snide
changed the title
cchaos
approved these changes
Apr 23, 2019
| const statLoadingSnippet = `<EuiStat | ||
| title={someNumber} | ||
| description="Total people" | ||
| isLoading={someNumber == undefined} |
cchaos
reviewed
Apr 23, 2019
…ough she doesn't like it. she's a good person.
cchaos
reviewed
Apr 23, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WIP, but feel free to comment on the actual solution. I'm wanna see if I can convert this to TS quickly while I'm in here.
cc @angorayc since she had some need for something like this and we discussed it in her earlier PR.
Checklist
This was checked in mobileThis was checked for breaking changes and labeled appropriatelyThis required updates to Framer X components