-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiGlobalToastListItem
convert to TS
#1880
EuiGlobalToastListItem
convert to TS
#1880
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the requests in global_toast_list_item.tsx
, my read is that we should restrict its children
to EuiToast
components and make the prop required. I'd like @chandlerprall's input on that decision, though
I agree, but I've been having difficulty getting that kind of typing against |
TypeScript does not support restricting |
0146e81
to
9c72666
Compare
@thompsongl PR updated Ta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go after this last change
Summary
Converted
EuiGlobalToastListItem
to TSChecklist