Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiHeaderLogo converted to TS #1892

Merged
merged 4 commits into from
May 3, 2019
Merged

EuiHeaderLogo converted to TS #1892

merged 4 commits into from
May 3, 2019

Conversation

theodesp
Copy link
Contributor

Summary

Converted EuiHeaderLogo to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@chandlerprall chandlerprall self-requested a review April 29, 2019 15:12
@thompsongl thompsongl mentioned this pull request Apr 29, 2019
Merged
10 tasks
@theodesp
Copy link
Contributor Author

theodesp commented May 3, 2019

@chandlerprall I have removed the title from 'EuiHeaderLogobut kept theiconTitle` property unused

@chandlerprall
Copy link
Contributor

jenkins test this

@chandlerprall
Copy link
Contributor

Looks like the unit test snapshots need to be updated: yarn test-unit -u and then everything will be good to merge!

@theodesp
Copy link
Contributor Author

theodesp commented May 3, 2019

PR updated

@chandlerprall
Copy link
Contributor

jenkins test this

@chandlerprall chandlerprall merged commit 27fd998 into elastic:master May 3, 2019
@chandlerprall
Copy link
Contributor

Thanks again @theodesp !

@thompsongl thompsongl mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theodesp @elasticmachine @chandlerprall @cchaos