-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add K6 overrides and more advanced theming system #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. This PR needs a rebase and a note in the CHANGELOG that we've adding two new themes, and then I think we're good to merge!
src/global_styling/k6/_index.scss
Outdated
@@ -0,0 +1,2 @@ | |||
// @import 'size'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this line?
@cjcenizal I rearranged how we import sass in regards to themes. Wanted to contain themes to their own directory vs having the files spread out in each folder that needed it. Also went ahead and wrote up docs for how to make themes. Give it another look, then we should be OK to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge this and cut a new release!
By providing a K6 theme over the K7 components, we're hoping to enable Kibana engineers to consume this framework today, while retaining a consistent look-and-feel in the Kibana UI.
Guidelines
K6 theme
The K6 theme consists of: