Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relative_options converted to TS #1921

Merged
merged 4 commits into from
May 9, 2019
Merged

relative_options converted to TS #1921

merged 4 commits into from
May 9, 2019

Conversation

theodesp
Copy link
Contributor

@theodesp theodesp commented May 7, 2019

Summary

Converted relative_options to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

chandlerprall
chandlerprall suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog entry needed

src/components/date_picker/super_date_picker/relative_options.ts Outdated Show resolved Hide resolved
@theodesp theodesp force-pushed the task/relative_options-to-TS branch from 0b77d3a to 84b0ba4 Compare May 8, 2019 08:17
@theodesp
Copy link
Contributor Author

theodesp commented May 8, 2019

@chandlerprall PR updated

@thompsongl
Copy link
Contributor

jenkins test this

chandlerprall
chandlerprall approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theodesp
Copy link
Contributor Author

theodesp commented May 9, 2019

@chandlerprall Conflicts resolved

@chandlerprall chandlerprall merged commit 9e3641c into elastic:master May 9, 2019
@chandlerprall
Copy link
Contributor

Thanks again, @theodesp !

@theodesp theodesp deleted the task/relative_options-to-TS branch May 29, 2019 09:17
@thompsongl thompsongl mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theodesp @elasticmachine @thompsongl @chandlerprall