Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Remove background-color from transition property list of form control mixin #1927

Merged
merged 2 commits into from
May 7, 2019

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented May 7, 2019

Fixes #1385

For firefox only to fix the flash of unstyled dropdown.

Before

After

Checklist

  • [ ] This was checked in mobile
  • [ ] This was checked in IE11
  • [ ] This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • [ ] Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos cchaos requested a review from chandlerprall May 7, 2019 18:53
@cchaos cchaos added the bug label May 7, 2019
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM; pulled locally and tested in FF & Chrome

@cchaos cchaos merged commit 3289ac1 into elastic:master May 7, 2019
@cchaos cchaos deleted the fix-FF-select branch May 7, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Janky EuiSelect behavior in Firefox
2 participants