Remove unused prop enum of l in EuiButton
#1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
reviewed
May 8, 2019
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ No public interface changes since `11.0.1`. | |||
|
|
|||
| - Fixed `EuiIconTip`'s typescript definition ([#1934](https://github.com/elastic/eui/pull/1934)) | |||
| - Reinstated `EuiIcon` component ability to handle `type` prop updates ([#1935](https://github.com/elastic/eui/pull/1935)) | |||
| - Removed unused prop enum of `l` in `EuiButton`' ([#1936](https://github.com/elastic/eui/pull/1936)) | |||
There was a problem hiding this comment.
Might have an extra ' in there.
thompsongl
reviewed
May 8, 2019
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ No public interface changes since `11.0.1`. | |||
|
|
|||
| - Fixed `EuiIconTip`'s typescript definition ([#1934](https://github.com/elastic/eui/pull/1934)) | |||
| - Reinstated `EuiIcon` component ability to handle `type` prop updates ([#1935](https://github.com/elastic/eui/pull/1935)) | |||
| - Removed unused prop enum of `l` in `EuiButton`' ([#1936](https://github.com/elastic/eui/pull/1936)) | |||
There was a problem hiding this comment.
Version just got bumped to 11.0.1, so you'll want to move this to just below the 'master' heading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it includes design elements include a screenshot or gif.
Checklist
[ ] This was checked in ### mobile[ ] This was checked in IE11[ ] This was checked in dark mode[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios