Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added width to FlexItem when gutter in FlexGrid is set to none #1941

Merged
merged 3 commits into from
May 10, 2019

Conversation

andreadelrio
Copy link
Contributor

Summary

Added width to EUIFlexItem when gutter in EUIFlexGrid is set to none. To fix #1493

Before (2 columns)
image
After (2 columns)
image

Checklist

  • [ ] This was checked in mobile
  • [ ] This was checked in IE11
  • [ ] This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios

@chandlerprall chandlerprall requested a review from cchaos May 10, 2019 18:34
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked in IE and FF as well. Just had a couple comments about comments ;)

src/components/flex/_flex_grid.scss Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@andreadelrio andreadelrio merged commit eae5417 into elastic:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlexItems have no width when gutterSize "none" applied to FlexGrid
2 participants