-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a webpack directive for naming icon chunks #1944
Add a webpack directive for naming icon chunks #1944
Conversation
Removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the changes, keeping the js
extension as part of the request.
Wondering about the diff to src-docs/src/i18ntokens.json
, though. Is it because comments are preserved now? Not sure what impact (if any) this has on the token changelog
I don't know what the role of |
nudging @chandlerprall |
The
No impact (and this is a conflict in the PR, master already has those new values, this PR didn't introduce them). The lines are used only in the docs https://elastic.github.io/eui/#/package/i18n-tokens |
btw I love this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to approval after @chandlerprall input.
Just make sure the CL entry goes to master
after resolving conflicts
b932619
to
82578a2
Compare
This PR adds a webpack directive (i.e. a comment) for naming icon chunks. The effect of this is obesrved in applications that use EUI and bundle through Webpack - instead of icon chunks such as e.g.
you get:
It's a small thing, but if a dynamic download were to fail then it might make tracking down the problem fractionally easier.
I think it still works if you drop the file extension from the
import()
, which means you get a cleaner[request]
value, but I thought I'd ask about that rather than just doing, since the.js
assets live alongside the.svg
assets.