Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siem app icon #1948

Merged
merged 3 commits into from
May 20, 2019
Merged

Siem app icon #1948

merged 3 commits into from
May 20, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented May 20, 2019

Summary

Replaces the analytics icon with the newest. I did a replace rather than a new one since it is mostly only being used by SIEM already in Kibana.

Note to @thompsongl. This will need to be backported, but because the backport will be in a pre compile-icons world, only the SVG should be brought over.

Also note that the yarn compile-icons when ran in master will change all icon files so I had to do this manually. I'm wondering if the prettier merge effected this someone. Didn't look too deeply into it.

image

image

Checklist

  • [ ] This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested a review from thompsongl May 20, 2019 05:11
@snide snide mentioned this pull request May 20, 2019
@snide
Copy link
Contributor Author

snide commented May 20, 2019

Assuming this passes review, feel free to merge and start the backport for #1942

We'll want to get this into Kibana before FF on Tuesday.

@thompsongl
Copy link
Contributor

Looks like it doesn't use the full viewbox (the main path is 28x32), and is not centered as a result.
Screen Shot 2019-05-20 at 9 53 45 AM

@thompsongl
Copy link
Contributor

@snide It makes the icon look slightly misaligned in the nav bar

@snide
Copy link
Contributor Author

snide commented May 20, 2019

Checking. Thought I'd fixed this last night. Maybe forgot to commit the updated one.
image

@snide
Copy link
Contributor Author

snide commented May 20, 2019

^^ updated. Good spot @thompsongl

@snide snide merged commit 9240492 into elastic:master May 20, 2019
@snide snide deleted the icon/siem branch May 20, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants